User fields on C channel #2632
Merged
User fields on C channel #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are still experimenting with user bits in the TL-C setting. However, it does appear necessary to control these bits at the very least for Releases and ProbeAcks which get transformed into Puts.
This was a total hack. Let's do things properly.
…lity Since the CacheCork does not hard-code this, the cache should.
terpstra
force-pushed
the
user-fields-on-c-channel
branch
from
81d58f3 to
3497cf8
Compare
ingallsj
approved these changes
Sep 9, 2020
hcook
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: other enhancement
Impact: API modification
Development Phase: implementation
Release Notes
C channel now has the same user bits A channel does.
This moves the responsibility for filling in AMBAProt on C-channel from the CacheCork to the caches.
However, it frees those caches to supply additional fields in their requests, which was previously impossible.
Time will tell if we need additional configuration flexibility between A- and C-channel fields.